home bbs files messages ]

Forums before death by AOL, social media and spammers... "We can't have nice things"

   comp.lang.c++.moderated      Moderated discussion of C++ superhackery      33,346 messages   

[   << oldest   |   < older   |   list   |   newer >   |   newest >>   ]

   Message 31,976 of 33,346   
   Martin B. to Dave Abrahams   
   Re: justifiable, ancient, or silly?   
   02 Mar 12 13:01:30   
   
   From: 0xCDCDCDCD@gmx.at   
      
   On 02.03.2012 11:40, Dave Abrahams wrote:   
   > on Wed Feb 29 2012, "James K. Lowden"  wrote:   
   >   
   >> I recently came across code testing passed strings that I'm guessing is   
   >> intended to be fast, but to me looks just awful.  Before I   
   >> suggest/offer fixes, I want to make sure I'm not missing something   
   >> obvious.   
   >   
   > Does the code work?  If so, that could be one of the best reasons not to   
   > make any suggestions.   
   >   
      
   Well, if you ain't gonna touch something else there, it probably should   
   stay as it is. Except that stuff that is in the codebase tends to get   
   copied over (and over).   
      
   So, even if nothing's done, at least an additional comment might be in   
   order. Even if it just says: "We don't know for sure why this is the way   
   it is -- DO NOT use in new code." :-)   
      
   cheers,   
   Martin   
      
   --   
   Good C++ code is better than good C code, but   
   bad C++ can be much, much worse than bad C code.   
      
      
         [ See http://www.gotw.ca/resources/clcm.htm for info about ]   
         [ comp.lang.c++.moderated.    First time posters: Do this! ]   
      
   --- SoupGate-Win32 v1.05   
    * Origin: you cannot sedate... all the things you hate (1:229/2)   

[   << oldest   |   < older   |   list   |   newer >   |   newest >>   ]


(c) 1994,  bbs@darkrealms.ca