TID: FMail-W64 2.2.0.0
TZUTC: 0100
CHRS: LATIN-1 2
MSGID: 2:341/234.1 65b55856
REPLY: 2:221/10 65b2aa42
25 Jan 2024 20:36, you wrote to me:

 CN>> I think that you have found the source of text corruption problems
 CN>> in Smapi/JamNNTPd: it may not be safe to use strcpy that way.

 TK> Wow..!

 TK> Could it be also the reason why there are no text corruption problems
 TK> in my OS/2 version of jamnntpd which is compiled with ancient gcc3 ?

I think so. I don't have those problems when compiling with MinGW for Win32,
either. It seems it depends on how each compiler implements the strcpy
function.

This may be a possible way to fix the corrupted From field in headers: in
nntpserv.c, instead of just removing this line:

 strcpy(mimefrom,&mimefrom[6]);

Replace it by:

 memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

There could also be issues with the Subject field. The next line:

 strcpy(mimesubj,&mimesubj[9]);

could be changed to:

 memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

As for the corruption in the body of messages posted with newsreaders that
support flowed text (like Thunderbird), I think it may be fixed by changing
this:

 strcpy(line,&line[1]);

to this:

 memmove(line,line+1,strlen(line));

These patches are for both JamNNTPd and SmapiNNTPd.

Carlos

--- GoldED+/W32-MSVC 1.1.5-b20180707
 * Origin: cyberiada (2:341/234.1)
SEEN-BY: 15/0 90/1 103/705 105/81 106/201 124/5016 128/260 135/225
SEEN-BY: 153/757 7715 154/10 30 203/0 218/700 221/0 6 226/30 227/114
SEEN-BY: 229/110 112 113 206 307 317 426 428 470 664 700 240/1120
SEEN-BY: 240/5832 266/512 280/464 5003 5555 282/1038 291/111 292/8125
SEEN-BY: 301/1 310/31 320/219 322/757 341/66 234 342/200 396/45 423/120
SEEN-BY: 460/58 256 1124 467/888 633/280 712/848 770/1 5020/400 5054/30
PATH: 341/234 280/464 460/58 229/426