TID: FMail-lnx64 2.2.1.0
TZUTC: 0200
CHRS: CP437 2
NOTE: Sylpheed 3.8.0beta1 (GTK+ 2.24.30; i686-pc-mingw32).
PID: JamNNTPd/Linux/IPv6 PIN-m32 20240127
REPLY: 2:341/234.1 65b55856
MSGID: 2:221/6.0 65b5ee00
Carlos Navarro wrote:

CN>  CN>> I think that you have found the source of text corruption
CN>  CN>> problems in Smapi/JamNNTPd: it may not be safe to use strcpy
CN>  CN>> that way.
CN>
CN>  TK> Wow..!
CN>
CN>  TK> Could it be also the reason why there are no text corruption
CN>  TK> problems in my OS/2 version of jamnntpd which is compiled with
CN>  TK> ancient gcc3 ?
CN>
CN> I think so. I don't have those problems when compiling with MinGW
CN> for Win32, either. It seems it depends on how each compiler
CN> implements the strcpy function.

Yep. I have been wondering for a long time that compiling the exactly same
code in different systems produce binaries that behave differently.

CN> This may be a possible way to fix the corrupted From field in
CN> headers: in nntpserv.c, instead of just removing this line:
CN>
CN>  strcpy(mimefrom,&mimefrom[6]);
CN>
CN> Replace it by:
CN>
CN>  memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);
CN>
CN> There could also be issues with the Subject field. The next line:
CN>
CN>  strcpy(mimesubj,&mimesubj[9]);
CN>
CN> could be changed to:
CN>
CN>  memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);
CN>
CN> As for the corruption in the body of messages posted with
CN> newsreaders that support flowed text (like Thunderbird), I think it
CN> may be fixed by changing this:
CN>
CN>  strcpy(line,&line[1]);
CN>
CN> to this:
CN>
CN>  memmove(line,line+1,strlen(line));

Have to try these asap! :D

'Tommi

---
 * Origin: rbb.fidonet.fi - Lake Ylo - Finland (2:221/6.0)
SEEN-BY: 15/0 30/0 90/1 103/705 105/81 106/201 124/5016 128/260 135/225
SEEN-BY: 153/757 7715 154/10 30 203/0 218/700 221/0 1 6 226/30 227/114
SEEN-BY: 229/110 112 113 206 307 317 426 428 470 664 700 240/1120
SEEN-BY: 240/5832 266/512 280/464 5003 5555 282/1038 291/111 292/8125
SEEN-BY: 301/1 113 812 310/31 320/219 322/757 335/364 341/66 234 342/200
SEEN-BY: 396/45 423/120 460/58 256 1124 467/888 633/280 712/848 770/1
SEEN-BY: 5020/400 1042 5054/30
PATH: 221/6 301/1 280/464 460/58 229/426