MSGID: 2:341/234.99 65bff558
REPLY: 2:341/234.1 65b55856
PID: JamNNTPd/Win32 1.3.3-c (beta 2)
CHRS: IBMPC 2
TZUTC: 0100
TID: CrashMail II/Win32 0.71
27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

 CN> This may be a possible way to fix the corrupted From field in headers:
 CN> in nntpserv.c, instead of just removing this line:

 CN>   strcpy(mimefrom,&mimefrom[6]);

 CN> Replace it by:

 CN>   memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

 CN> There could also be issues with the Subject field. The next line:

 CN>   strcpy(mimesubj,&mimesubj[9]);

 CN> could be changed to:

 CN>   memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

 CN> As for the corruption in the body of messages posted with newsreaders
 CN> that support flowed text (like Thunderbird), I think it may be fixed by
 CN> changing this:

 CN>   strcpy(line,&line[1]);

 CN> to this:

 CN>   memmove(line,line+1,strlen(line));

 CN> These patches are for both JamNNTPd and SmapiNNTPd.

To prevent other potential problems, it is also convenient to do these other
modifications in nntpserv.c:

Change every occurrence (there are 3) of:
 strcpy(article,&article[1]);
to:
 memmove(article,article+1,strlen(article));

Change:
 strcpy(from,&from[1]);
to:
 memmove(from,from+1,strlen(from));

Change:
 strcpy(subject,&subject[4]);
to:
 memmove(subject,subject+4,strlen(subject)+3);

And change:
 strcpy(text,&text[c]);
to:
 memmove(text,text+c,strlen(text)+c-1);

Carlos

--- Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
 * Origin: cyberiada-NNTP (2:341/234.99)
SEEN-BY: 15/0 90/1 103/705 105/81 106/201 124/5016 128/260 135/225
SEEN-BY: 153/757 7715 154/10 30 203/0 218/700 221/0 6 226/30 227/114
SEEN-BY: 229/110 112 113 206 307 317 426 428 470 664 700 240/1120
SEEN-BY: 240/5832 266/512 280/464 5003 5555 282/1038 291/111 292/8125
SEEN-BY: 301/1 310/31 320/219 322/757 341/66 234 342/200 396/45 423/120
SEEN-BY: 460/58 256 1124 467/888 633/280 712/848 770/1 5020/400 5054/30
PATH: 341/234 280/464 460/58 229/426