home bbs files messages ]

Forums before death by AOL, social media and spammers... "We can't have nice things"

   linux.debian.kernel      Debian kernel discussions      2,884 messages   

[   << oldest   |   < older   |   list   |   newer >   |   newest >>   ]

   Message 1,107 of 2,884   
   Salvatore Bonaccorso to Ben Hutchings   
   Bug#1118465: Regression: linux-image-5.1   
   22 Oct 25 14:50:02   
   
   XPost: linux.debian.bugs.dist   
   From: carnil@debian.org   
      
   Hi Ben,   
      
   In case Axel can confirm, there is a "off-by-one" in one of the Fixes:   
      
   On Tue, Oct 21, 2025 at 10:27:37PM +0200, Ben Hutchings wrote:   
   > Control: tag -1 upstream patch moreinfo   
   >   
   > Does this patch fix it?   
   >   
   > Ben.   
   >   
   > --   
   > Ben Hutchings   
   > Editing code like this is akin to sticking plasters on the bleeding   
   > stump of a severed limb. - me, 29 June 1999   
      
   > From 4f97e494a3e2500166be4e8b53b4c412d6a44a9f Mon Sep 17 00:00:00 2001   
   > From: Ben Hutchings    
   > Date: Tue, 21 Oct 2025 22:18:49 +0200   
   > Subject: [PATCH] usbnet: Report link up even when the interface is not yet up   
   >   
   > Even after commit 466d393700f9 ("net: usbnet: Fix the wrong   
   > netif_carrier_on() call"), usbnet isn't calling netif_carrier_on() in   
   > all the same cases it would before.  Specifically, if the link is   
   > reported up before EVENT_DEV_OPEN is set, netif_carrier_on() may no   
   > longer be called.   
   >   
   > Fix this by checking for EVENT_LINK_CARRIER_ON first in   
   > __handle_link_change(), before EVENT_DEV_OPEN.   
   >   
   > References: https://bugs.debian.org/1118465   
   > Reported-by: Axel Beckert    
   > Fixes: 0d9cfc9b8cb1 ("net: usbnet: Avoid potential RCU stall on LINK_CHANGE   
   event")   
   > Fixes: 466d393700f9 ("net: usbnet: Fix the wrong netif_carrier_on() call")   
      
   Should that be   
   Fixes: 8466d393700f ("net: usbnet: Fix the wrong netif_carrier_on() call")   
   ?   
      
   Spotted it while checking to see ee which other stable series are affected.   
      
   Regards,   
   Salvatore   
      
   --- SoupGate-Win32 v1.05   
    * Origin: you cannot sedate... all the things you hate (1:229/2)   

[   << oldest   |   < older   |   list   |   newer >   |   newest >>   ]


(c) 1994,  bbs@darkrealms.ca