From: vincent.debian@free.fr   
   Copy: 1124597@bugs.debian.org   
   Copy: debian-go@lists.debian.org (Debian-Go Mailing List)   
      
   Le 2026-02-06 22:57, Simon Josefsson a écrit :   
   > Vincent Blut  writes:   
   >    
   > > Would someone in the team be willing to review this new package?   
   > >   
   > > https://salsa.debian.org/go-team/packages/golang-github-jezek-xgb   
   >    
   > Looks good to me.  Some nitpicks:   
   >    
   > I think you want to add the names from AUTHORS to debian/copyright since   
   > it claims they are authors for copyright purposes.   
      
   *nod*   
       
   Listing them individually is definitely more appropriate than the   
   current "The XGB Authors" copyright notice.   
      
   > The file xf86vidmode/xf86vidmode.go says 'This file is automatically   
   > generated from xf86vidmode.xml.', thus I think it should be re-generated   
   > at build-time from source.  I can't find xf86vidmode.xml in the project,   
   > maybe something to ask upstream about.  Same for xf86dri/xf86dri.go and   
   > several other files, grep for 'This file is automatically generated'.   
      
   Indeed, XCB binding provided by this project are pre-built from the XML-XCB   
   protocol   
   descriptions available there:   
   https://gitlab.freedesktop.org/xorg/proto/xcbproto/-/tree/master/src   
       
   > Is 'Archive: GitHub' a standard header for debian/upstream/metadata?   
      
   Could you clarify what you mean by "standard header"?    
      
   > I didn't know it could replace debian/watch, interesting!   
      
   I'm not sure this is documented anywhere, but you can see the logic used when   
   uscan does not find any watch file:   
   https://salsa.debian.org/debian/devscripts/-/blob/main/lib/Devsc   
   ipts/Uscan/FindFiles.pm?ref_type=heads#L155   
       
   In a nutshell, it creates a watch file on-the-fly and uses a template   
   based on the value of the "Archive:" field.   
      
   > Per debian-policy 3.4.2 I would add the following to debian/control's   
   > "Description:" field:   
   >    
   >  .   
   >  This package contains the Go development library.   
      
   dh-make-golang appends "(library)" to the synopsis when creating a library   
   package. Is it really usefull to duplicate this information in the long   
   description?   
       
   https://github.com/Debian/dh-make-golang/blob/master/template.go#L172   
      
   > /Simon   
      
   Thanks for your initial review Simon!   
      
   Cheers,   
   Vincent   
      
   -----BEGIN PGP SIGNATURE-----   
      
   iHUEABYKAB0WIQSRJQjHKbAUfuoc+DAQn1qAt/bgAQUCaYpnmAAKCRAQn1qAt/bg   
   AX80AQDrCrn5I8EWuhkSGDhHHjUVoT6Cy+ZejzYbcd5Gjdv84QEA1tR95u8UvS48   
   FtU+1KBdQOuxxI1tNh6dxsq+7gCmAgE=   
   =TT7R   
   -----END PGP SIGNATURE-----   
      
   --- SoupGate-Win32 v1.05   
    * Origin: you cannot sedate... all the things you hate (1:229/2)