From: bunk@debian.org
On Thu, Feb 12, 2026 at 08:01:55PM +0100, Lee Garrett wrote:
> Hi Adrian,
>
> On 12/02/2026 16:06, Adrian Bunk wrote:
> > Source: borgbackup
> > Version: 1.4.3-2
> > Severity: important
> >
> > borgbackup (1.4.3-2) unstable; urgency=medium
> > ...
> > * Skip build tests when running with DEB_BUILD_OPTIONS=nocheck.
> > ...
> > -- Lee Garrett Sun, 21 Dec 2025 22:35:39 +0100
> >
> >
> > This change was obviously never tested, because otherwise it would
> > have been noticed before uploading that the condition is inverted
> > and tests are now skipped when nocheck is *dis*abled.
> >
> > Testing the change would have also revealed that no change was
> > necessary at all, as documented dh_auto_test is automatically
> > skipped with nocheck.
> >
> > Please revert this bogus change.
>
> Thanks for pointing out the bug. Indeed, you are correct that the test logic
> is inverted.
>
> I did actually test this, and retested it right now, and just deleted the
> first draft of this mail after finding the actual issue in my setup.
>
> Turns out that I set DEB_BUILD_OPTIONS in my ~/.sbuildrc, and that takes
> higher precedence than what is set on the CLI. Which is also the reason I
> added the conditional in the first place; dh_auto_test didn't seem to behave
> as documented.
Your change did not disable running the tests with nocheck.
If dh_auto_test didn't seem to behave as documented as you claim,
and you did test your change as you claim, then you would have
seen that tests are still running with nocheck set.
The only effect of your change was disabling the tests when nocheck
was NOT set.
> Greets,
> Lee
cu
Adrian
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|
