XPost: linux.debian.devel.release
From: plorenzo@disroot.org
This is a multi-part MIME message sent by reportbug.
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: runit-services@packages.debian.org, plorenzo@disroot.org
Control: affects -1 + src:runit-services
User: release.debian.org@packages.debian.org
Usertags: pu
Dear Release Team,
I'm looking for pre-approval for a runit-services stable-update
[ Reason ]
Fix #1126699 and #1121099 for Trixie fresh install: for users
upgrading from 0.9.1 the fix will take effect after the first
system reboot.
[ Impact ]
1126699: duplicate instances of certain services are run during
the boot sequence: it's hard to predict how bad this is, it
depends on the service. For some services the duplicate
instance will just crush logging a misleading message on the
system logger; other services may just be able to run duplicate
instances without issues (except for wasting resources) or may
subtly misbehave.
1121099: slim forks in background but runit supervision expect
services to run in foreground: a second instance is started which
then blocks because the tty is aready used by the first instance.
the bug appear when a user logs out and try to restart slim which
does not respond to signals, except to sigkill. It's not straightforward
to understand why the slim service does not respond to sigterm
and that there are two instances running at the same time.
Also: the runit-services package is imported as is downstream at
Devuan where runit is a popular choice and slim is the default
login manager (in fact both bug reports came from downstream)
[ Tests ]
I tested on my system (unstable) that both bugs are fixed
[ Risks ]
Fix for 1121099 (slim) is a one line simple change; fix for
1126699 is a bit more complex but the code largely matches
another component of runit (/usr/lib/runit/run_sysv_scripts)
that is already in stable: I think the changes are low risk.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in stable
[x] the issue is verified as fixed in unstable
[ Changes ]
* slim: run slim in foreground
* dbus.dep-fixer: correctly check for existing runit services definitions
Thanks,
Lorenzo
diff -Nru runit-services-0.9.1/debian/changelog runit-services-0
9.1+deb13u1/debian/changelog
--- runit-services-0.9.1/debian/changelog 2025-04-10 10:52:56.000000000 +0200
+++ runit-services-0.9.1+deb13u1/debian/changelog 2026-02-10 19:
8:57.000000000 +0100
@@ -1,3 +1,14 @@
+runit-services (0.9.1+deb13u1) trixie; urgency=medium
+
+ * slim: start in foreground with -n.
+ + thanks: Andrew Bower (Closes: #1121099)
+ * dbus-dep.fixer:
+ - correctly test for existing services definitions
+ - only start dbus services, even with the sysv override.
+ + thanks: S. Osipiuk (Closes: #1126699)
+
+ -- Lorenzo Puliti Tue, 10 Feb 2026 19:08:57 +0100
+
runit-services (0.9.1) unstable; urgency=medium
* deploy rsyslog logrotate snipped also during upgrade (Closes: #1102482)
diff -Nru runit-services-0.9.1/sv/dbus.dep-fixer/run runit-servi
es-0.9.1+deb13u1/sv/dbus.dep-fixer/run
--- runit-services-0.9.1/sv/dbus.dep-fixer/run 2023-01-19 15:02:19.000000000
+0100
+++ runit-services-0.9.1+deb13u1/sv/dbus.dep-fixer/run 2026-02-10
19:08:57.000000000 +0100
@@ -16,7 +16,17 @@
[ ! -x "$script" ] && continue
path=$(realpath "$script")
name=${path##*/}
+ [ -f /etc/runit/override-sysv.d/"$name".block ] && continue
+ [ -f /etc/runit/override-sysv.d/"$name".pkgblock ] && continue
+ if [ -f /etc/runit/override-sysv.d/"$name".sysv ]; then
+ if grep -q "$name:.*dbus" /etc/init.d/.depend.start ; then
+ "$script" start
+ fi
+ continue
+ fi
+ [ -L "/etc/service/$name" ] && continue
[ -d "/etc/sv/$name" ] && continue
+ [ -d "/usr/share/runit/sv.current/$name" ] && continue
if grep -q "$name:.*dbus" /etc/init.d/.depend.start ; then
"$script" start
fi
diff -Nru runit-services-0.9.1/sv/slim/run runit-services-0.9.1+
eb13u1/sv/slim/run
--- runit-services-0.9.1/sv/slim/run 2025-03-10 00:35:25.000000000 +0100
+++ runit-services-0.9.1+deb13u1/sv/slim/run 2026-02-10 13:27:50.000000000
+0100
@@ -18,4 +18,4 @@
exec 2>&1
-exec ##bin##
+exec ##bin## -n
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|
