From: wason@wasontech.com   
      
   Tobi,   
      
   I have made the requested corrections, and the Salsa tests are now   
   passing since robotraconteur has been added to the Debian Unstable   
   distribution.   
      
     dget -x   
   https://mentors.debian.net/debian/pool/main/r/robotraconteur-com   
   anion/robotraconteur-companion_0.4.2-1.dsc   
      
   I see the robotraconteur package has been imported into the Ubuntu 26.04   
   distribution, and I would like to have the librobotraconteur-companion   
   library available as well. The cutoff is Feb 19 so time is short!   
      
   Thanks,   
      
   -John   
      
   On 12/6/2025 11:47 AM, Tobias Frost wrote:   
   > Control: tags -1 moreinfo -confirmed   
   >   
   > Hi John   
   >   
   > (incomplete review, especially did not do a copyright review)   
   >   
   > d/copyright: It is not recommended to have a different license for   
   > debian/* and upstream. I'd recommend to align the debian/* license to   
   > the upstream license. (It can create difficulties upstreaming patches,   
   > for example, as Apache and GPL-2 is not considered to be compatible.   
   >   
   > d/control:   
   > If a versioned Build-Depends is fulfiled sinc at least oldstable, please   
   > remove the version constraint on the B-D. Thats e.g for cmake,   
   > libboost-all-dev and libssl-dev   
   > Regarding libboost-all-dev: Do you really neeed "all-dev" or can you   
   > limit the B-Ds to the parts of boost you really need?   
   >   
   > d/*install - please use ${DEB_HOST_MULTIARCH} instead of "*" for the   
   > architecture triplet.   
   > (/usr/lib/*/*.so will become /usr/lib/${DEB_HOST_MULTIARCH}/*.so   
   >   
   > package-name-doesnt-match-sonames is a valid lintian concern.   
   > Don't override, name the package according to Debian Policy.   
   >   
   > Cheers,   
      
   --- SoupGate-Win32 v1.05   
    * Origin: you cannot sedate... all the things you hate (1:229/2)