From: cascardo@debian.org
--6fh2T9LUoo2vUOsi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Feb 20, 2026 at 10:30:48AM -0500, Nicolas Mora wrote:
> Hello,
>
> I don't deny you have an issue, but setting the flag critical for an issue
> you have with the package in stable may be a little bit much?
>
Sorry, I was following the criteria that it makes me lose data (the
video that I wanted to save) that cannot be restored (no way to backup
upfront new videos). That has made some family members frustrated that
the NVR I setup does not work reliably.
I don't mind that the priority is downgrade, as long as the issue is
taken seriously and it results in an updated package. I would rather not
have to rebuild the package myself everytime there is an update.
> The bug also flags the package for autoremoval in testing...
>
> Concerning your issue, can you be more specific on the problems?
> I'm using motion for a long time myself and I never had such problems.
> Maybe you can look at your system configuration, for example if you save the
> files on a remote location that could lead to files lock issues?
>
> If the problem doesn't come from the package itself, we'll transfer it
> upstream then.
>
I had the chance to look at it. Unfortunately, it seems upstream has
moved the codebase, even changing from C to C++. From what I could
conclude, the new codebase does not suffer from the same issue, that is,
it is already fixed there. But not the version in Debian stable.
Attached is a proposed fix (that needs to be properly massaged to be
applied for an archive upload). If attribution to the fix can be added,
please use:
Thadeu Lima de Souza Cascardo
Thanks.
Cascardo.
> /Nicolas
--6fh2T9LUoo2vUOsi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="motion_4.7.0-3+fix1.debdiff"
Content-Transfer-Encoding: quoted-printable
diff -Nru motion-4.7.0/debian/changelog motion-4.7.0/debian/changelog
--- motion-4.7.0/debian/changelog 2025-03-30 11:32:58.000000000 -0300
+++ motion-4.7.0/debian/changelog 2026-02-21 15:56:27.000000000 -0300
@@ -1,3 +1,9 @@
+motion (4.7.0-3+fix1) unstable; urgency=medium
+
+ * Fix file descriptor leak.
+
+ -- Thadeu Lima de Souza Cascardo Sat, 21 Feb 2026
15:56:27 -0300
+
motion (4.7.0-3) unstable; urgency=medium
[Carles Pina i Estany]
diff -Nru motion-4.7.0/debian/patches/fix_file_leak.patch motion
4.7.0/debian/patches/fix_file_leak.patch
--- motion-4.7.0/debian/patches/fix_file_leak.patch 1969-12-31 2
:00:00.000000000 -0300
+++ motion-4.7.0/debian/patches/fix_file_leak.patch 2026-02-21 1
:55:57.000000000 -0300
@@ -0,0 +1,12 @@
+Index: motion-4.7.0/src/ffmpeg.c
+===================================================================
+--- motion-4.7.0.orig/src/ffmpeg.c
++++ motion-4.7.0/src/ffmpeg.c
+@@ -958,6 +958,7 @@ static int ffmpeg_set_outputfile(struct
+ av_strerror(retcd, errstr, sizeof(errstr));
+ MOTION_LOG(ERR, TYPE_ENCODER, NO_ERRNO
+ ,_("Could not write ffmpeg header %s"),errstr);
++ avio_close(ffmpeg->oc->pb);
+ ffmpeg_free_context(ffmpeg);
+ return -1;
+ }
diff -Nru motion-4.7.0/debian/patches/series motion-4.7.0/debian/patches/series
--- motion-4.7.0/debian/patches/series 2024-08-27 15:43:22.000000000 -0300
+++ motion-4.7.0/debian/patches/series 2026-02-21 15:55:38.000000000 -0300
@@ -1,2 +1,3 @@
change-paths_set-debian-paths.patch
spelling.patch
+fix_file_leak.patch
--6fh2T9LUoo2vUOsi--
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEE34E7Im3TmixTD299CrplA3L9lXEFAmmaAfUACgkQCrplA3L9
lXH8ug/9HaMzrqUeCxQKPuzNITdQpLBEGQiKJBk4pcRpmabmbCwEZgirBKfk2wtY
O1jYQWojZOXi6IuBDcCwwgidTZ/d54rpC8cxIPgjdlGK86uHFo2xNN8AEn0NW88k
TXmhCEIvZ8v1Hwj4991PSfYQ+J5GSjP7ADzaX9/a+dLz6vsCueE6P+U5DCdKogDq
pvYL0bApIGTzPe+qADo1LDMzLsv0rGhxT3sTC7N6Ee/1/Po4RE/JtXy706IxfDSR
4RJGGSduVPJBgaqjNGJgVtaN+LL0Xilb9iPkJCQsaXDKurAxVAW5ilzszPIbsB/d
77eeo6oXSQixDvorqT4JKh7Uw5PHti+XwffbFrnhsjVe8G+IEw3/K76JqYrvjPkj
oaiHVcKUlX1Qv8EZDsRyl250uSibiVPlXc/5LYfqzTJNF3L69ltjfjcR/owMPKsL
prE/vM7qtMn2NhGw/DydRFWCiJmE6u/Z5WgMl397+6BKCoXEIHakqXoIBf4U3l0S
DMhIg0+UbBe7i+M4VHVmRNTEkVMOBz848ZTlBKrqfY3YNWE+jrYmKbrkXhNMW+TE
b6X9uDQzRbnYxL16P3/3baIpqGbyWGQ/xrnA/IBOnFihYZq30ctYeUMhly5G2rc3
6HNY23jsv55f78OpJHbPPfYRvmUJx/zycAMZU7f77ZTkvr/zWMw=
=EiS3
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)
|
