Hello Michiel!

30 Jun 14 15:20, you wrote to me:

 MV> Hello Andrew,

 MV> When line ends with just the baud rate field as fo rexample in
 MV> 2:280/127, MakeNL addes a trailing comma when it is not there:

 MV> Pvt,127,Trapgate_Test,Brunssum,Frans_Lupschen,-Unpublished-,300,

 MV> It does not add a trailing comma, when the baud rate is not the last
 MV> field.

 MV> FTS-5000 allows the trailing comma, but does not require it.

Effective with v3.4.4 (committed to CVS today), MakeNL will no longer add a 
trailing comma after the baudrate field when there are no flags listed.

 MV> I think MAkeNl should not forcefully add a trailing comma. It should
 MV> also not remove it when it is present in the submitted segment. It
 MV> should just pass it "as is" in the case that field seven is the last
 MV> field.

Due to the design of the program, this is difficult to achieve.  As each line 
is read from the input segment, it is broken down into its component parts 
(keyword, number, name, location, sysop, phone, baudrate, and flags.)  After 
the validation and error checking that MakeNL does, these individual 
components are reassembled into a nodelist line, which is then written to the 
output file in the proper format.  I just added a check that eliminates adding 
the comma and the flags if there are no flags.

 MV> In Zone 2 we have the odd situation that the R28 segment that I edit
 MV> does not have the trailing comma. When I run it trough MakeNl, it adds
 MV> the comma. I submit it to the ZC, who runs it through a filter
 MV> (ERRFLAGS) that removes the trailing comma. It reports it as an error.
 MV> And then the ZC's MakeNl puts the comma back in....

When the 3.4.4 version is released, this situation will be eliminated.  I 
note, however, that FTS-5000 allows the trailing comma, so ErrFlags is broken 
if it flags that as an error.

 MV> We could make it an option, but just not touching the trailing comma
 MV> would be fine with me.

The change I have made will no longer add one that is not there, but it will 
also strip one that is.  Given the number of nodes presently existing with no 
flags, I don't see this as a high priority at this time.

Andrew

--- GoldED+/LNX 1.1.5-b20130910
 * Origin: Phoenix BBS * phoenix.bnbbbs.net:2323 (1:320/219)