home bbs files messages ]

Just a sample of the Echomail archive

<< oldest | < older | list | newer > | newest >> ]

 Message 1424 
 Andrew Leary to Wilfred van Velzen 
 MakeNL 3.4.6 Release 
 02 Dec 16 10:24:22 
 
Hello Wilfred!

02 Dec 16 13:11, you wrote to me:

 WV> Your using strcpy to copy overlapping strings. The behaviour of strcpy
 WV> when source and destination overlap is undefined for all definitions
 WV> of strcpy I know. So it might work, or it might not, for all
 WV> permutations of compilers, os's and compiler options, that makenl is
 WV> compiled on.

 WV> I suggest:

 WV>                  memmove(templine, templn2, strlen(templn2) + 1);

 WV> The same is true for the fts5.c file, with about the same code...

Good point.  I will make that change today.  The released files do work, as 
the compilers used (OpenWatcom 1.9 and gcc 5.3.0) apparently do the copy left 
to right, so the source isn't overwritten until after it has been read and 
copied to the destination.  For portability purposes, it should be fixed.

Thanks for the report.

Andrew

--- GoldED+/LNX 1.1.5-b20160322
 * Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)

<< oldest | < older | list | newer > | newest >> ]

(c) 1994,  bbs@darkrealms.ca